Prevent guessed types from being anything but namespaces#4102
Merged
vinistock merged 2 commits intorubydex_adoption_feature_branchfrom May 8, 2026
Merged
Conversation
vinistock
added
bugfix
Base automatically changed from
vs_remove_old_indexer
to
rubydex_adoption_feature_branch
May 8, 2026 18:33
alexcrocha
approved these changes
May 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
A small bug I noticed when playing around with the fully migrated LSP: a guessed type might accidentally match a constant that's not a module or class (by nature of how the guessing works). We never want to return a constant though because that's not a valid type and that ends up crashing completion.
Implementation
The check should not just verify for
nil, but rather confirm the returned type of the declaration.Automated Tests
Added a couple of tests that fail before.